-
Notifications
You must be signed in to change notification settings - Fork 19
Conversation
3f7494e
to
69091ec
Compare
5ceab4b
to
da9ff40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels awesome. Tested it in your phoenix branch in different resolutions. They made sense as well. One small visual improvement would be, to have a sliding animation, pulling the menu in from the left and pushing it out to the left again on close. Left some small comments for your consideration as well. Overall really nice work 🚀 🎆
@kulmann Pushed fixes after the review and added the animation. Pls re-review 🙂 It's in a separate commit to make it easier to navigate |
68640a2
to
2aea840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks super cool! From my point of view the animation could be quicker than 500ms, maybe 200ms.
2aea840
to
e68ac58
Compare
I was trying originally 300 and that seemed too rushed. Since it's moving the whole file list in web app it felt too "jumpy". But that might be just my personal feeling 🙈 I am happy to change it in case you think it really should be faster. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with the transition duration a bit. I'd prefer 200ms. But try what you think is best and let's get more feedback from different people. ;-)
Added animation, content wrapper and small fixes after review
e68ac58
to
a6cf97d
Compare
@kulmann Ok, I changed it to 200 😉 Damn, auto review dismiss, in this situation, it's kind of annoying 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description
Deprecated appNavigation component and created sidebar component.
Screenshot